feat(sighash): verify required SighashAll [part 7/7] #917
Open
glevco wants to merge 1 commit intorefactor/verification/scriptsfrom
Open
feat(sighash): verify required SighashAll [part 7/7] #917glevco wants to merge 1 commit intorefactor/verification/scriptsfrom
glevco wants to merge 1 commit intorefactor/verification/scriptsfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactor/verification/scripts #917 +/- ##
================================================================
Coverage ? 85.42%
================================================================
Files ? 284
Lines ? 22666
Branches ? 3447
================================================================
Hits ? 19363
Misses ? 2612
Partials ? 691 ☔ View full report in Codecov by Sentry. |
glevco
force-pushed
the
refactor/verification/scripts
branch
from
0b319db to
278f3e7
Compare
glevco
force-pushed
the
feat/sighash/verify-sighash-all
branch
from
e87f415 to
10b2b0a
Compare
glevco
force-pushed
the
refactor/verification/scripts
branch
from
278f3e7 to
fc82c06
Compare
glevco
force-pushed
the
feat/sighash/verify-sighash-all
branch
from
10b2b0a to
5fe75e8
Compare
This was referenced Jan 29, 2024
glevco
force-pushed
the
refactor/verification/scripts
branch
from
fc82c06 to
ae27bbb
Compare
glevco
force-pushed
the
feat/sighash/verify-sighash-all
branch
from
5fe75e8 to
7011e24
Compare
msbrogli
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #916
Motivation
Verify that all transactions are signed with
SighashAll.Acceptance Criteria
SighashAll.